Artyom / Refresh Token Bugs and a Login Redirect #162
Open
Conversation
Member
Author
|
oh yeah, the branch name was renamed so its a new PR, but the changes are mostly the same as last PR except also added a Login Redirect |
matthewd-so
reviewed
Nov 18, 2025
|
|
||
| async generateSignInLink(email: string): Promise<string> { | ||
| const actionCodeSettings = { | ||
| // Why this localhost lmao |
Contributor
There was a problem hiding this comment.
Yeah we will replace this in production. It is localhost for now because firebase requires a valid url for email link sign in
matthewd-so
reviewed
Nov 18, 2025
| }; | ||
|
|
||
| // Checks if the access token has expired or not | ||
| export const validateAccessToken = (decodedToken: DecodedJWT): boolean => { |
Contributor
There was a problem hiding this comment.
Is the logic backwards?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
You can test for both fixed bugs with one method
You can force a refresh on every axios request
AuthUtils.tson the frontend and make thevalidateAccessTokenalways return false (simulating the access token being expired)authService.tson the backend and make therenewToken()function always through an error, this will simulate the refresh token being expired/profileand you will be redirect to the/login, refreshing the page also redirects you to the login, so basically doing anything at all will redirect youWhat should reviewers focus on?
BaseAPIClient.ts, if we have more complicated permissions then it might need tweakingChecklist